Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aggregate not matching null values #6043

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

davimacedo
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #6043 into master will decrease coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6043      +/-   ##
=========================================
- Coverage   93.93%   93.4%   -0.53%     
=========================================
  Files         164     164              
  Lines       11110   11112       +2     
=========================================
- Hits        10436   10379      -57     
- Misses        674     733      +59
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.97% <100%> (+0.03%) ⬆️
...dapters/Cache/RedisCacheAdapter/KeyPromiseQueue.js 0% <0%> (-95.46%) ⬇️
src/Adapters/Cache/RedisCacheAdapter/index.js 15.9% <0%> (-84.1%) ⬇️
src/RestWrite.js 93.56% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a754b88...a79b34b. Read the comment docs.

@davimacedo davimacedo requested a review from dplewis September 11, 2019 04:20
@dplewis dplewis merged commit 8477681 into parse-community:master Sep 11, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fix: aggregate not matching null values

* Exclude Postgres from this new test - it does not even support  and  is not working correctly - should be addressed separately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate query with null value returns incorrect results
2 participants