-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Graph Authentication #6051
Conversation
Microsoft Graph Authentication
Codecov Report
@@ Coverage Diff @@
## master #6051 +/- ##
==========================================
- Coverage 93.73% 93.71% -0.03%
==========================================
Files 164 165 +1
Lines 11151 11161 +10
==========================================
+ Hits 10452 10459 +7
- Misses 699 702 +3
Continue to review full report at Codecov.
|
@alann-maulana thanks for tackling this. Could you please add some test cases? |
@davimacedo ok, I'll try it |
The CI is failing both for the lint and for the tests. Can you please take a look here and fix it? |
@davimacedo fixed it (I think) but still there is an error 😐 |
@alann-maulana yes... this test is still failing:
|
Yup, now the error goes to Parse.Push
never touch them btw 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is actually hanging. It has just run again and passed. It looks good to me! @dplewis do you want to take a look at this one here?
* add microsoft graph auth * change mail to id * add graph user id and email * add microsoft graph auth test case * remove validating auth data using mail * add test case to AuthenticationAdapters * fix indentation * fix httpsRequest and fakeClaim not found * add newline eof last * fix test in auth adapter * fix unhandled promise rejection
Add authentication using Microsoft according Microsoft Graph REST API v1.0