Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent afterFind with saving objects #6127

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Prevent afterFind with saving objects #6127

merged 1 commit into from
Oct 15, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 11, 2019

Fixes: #6088

@codecov
Copy link

codecov bot commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #6127 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6127      +/-   ##
==========================================
- Coverage   93.75%   93.75%   -0.01%     
==========================================
  Files         165      165              
  Lines       11199    11202       +3     
==========================================
+ Hits        10500    10502       +2     
- Misses        699      700       +1
Impacted Files Coverage Δ
src/rest.js 98.86% <100%> (ø) ⬆️
src/RestQuery.js 95.47% <100%> (+0.03%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26008f...a546036. Read the comment docs.

acinader
acinader approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dplewis dplewis merged commit 095164b into master Oct 15, 2019
@dplewis dplewis deleted the afterFind-on-update branch October 15, 2019 20:50
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis
Prevent afterFind with saving objects (parse-community#6127)
fa88041 
Fixes: parse-community#6088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

@davimacedo davimacedo Awaiting requested review from davimacedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why afterFind is triggered always before beforeSave?
2 participants
@dplewis @acinader