fix(GraphQL): fix graphql mutations not returning updated information #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was spotted when an updated field is modified in beforeSave, but the unmodified version is returned if requested by the resolver.
For example
```grapqhl
mutation UpdateTitle($id: ID!, $title: String!) {
updateSomeObject(id: $id, fields: { title: $title }) {
id
title
slug
}
}
```
In the above, if we modify the `title` by let's say, trimming it - the resolved `title` will not reflect this change, and instead just return the input variable. Other resolved fields that are not sent within the `fields` input are returned properly using the latest data.
Codecov Report
@@ Coverage Diff @@
## master #6130 +/- ##
==========================================
- Coverage 93.73% 93.72% -0.01%
==========================================
Files 165 165
Lines 11210 11210
==========================================
- Hits 10508 10507 -1
- Misses 702 703 +1
Continue to review full report at Codecov.
|
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…unity#6130) This issue was spotted when an updated field is modified in beforeSave, but the unmodified version is returned if requested by the resolver. For example ```graphql mutation UpdateTitle($id: ID!, $title: String!) { updateSomeObject(id: $id, fields: { title: $title }) { id title slug } } ``` In the above, if we modify the `title` by let's say, trimming it - the resolved `title` will not reflect this change, and instead just return the input variable. Other resolved fields that are not sent within the `fields` input are returned properly using the latest data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs when an updated field is modified in beforeSave, but the unmodified version is returned if requested by the resolver.
For example
In the above, if we modify the
titleby let's say, trimming it - the resolvedtitlewill not reflect this change, and instead just return the input variable. Other resolved fields that are not sent within thefieldsinput are returned properly using the latest data.