Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple Game Center #6143

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Support Apple Game Center #6143

merged 1 commit into from
Oct 19, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 18, 2019

Fixes: #5984

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #6143 into master will increase coverage by 10.45%.
The diff coverage is 98.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6143       +/-   ##
===========================================
+ Coverage   83.32%   93.78%   +10.45%     
===========================================
  Files         165      166        +1     
  Lines       11213    11271       +58     
===========================================
+ Hits         9343    10570     +1227     
+ Misses       1870      701     -1169
Impacted Files Coverage Δ
src/Adapters/Auth/apple.js 87.09% <ø> (ø) ⬆️
src/Adapters/Auth/index.js 93.33% <100%> (+0.11%) ⬆️
src/Adapters/Auth/gcenter.js 98.24% <98.24%> (ø)
src/RestWrite.js 93.72% <0%> (+0.33%) ⬆️
src/Routers/UsersRouter.js 94.19% <0%> (+0.64%) ⬆️
src/Controllers/UserController.js 94.39% <0%> (+0.93%) ⬆️
src/Adapters/Storage/Postgres/PostgresClient.js 85.71% <0%> (+7.14%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.09% <0%> (+94.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bcc72...c88d8bd. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coool

@dplewis dplewis merged commit c1a217c into master Oct 19, 2019
@dplewis dplewis deleted the game-center branch October 19, 2019 00:04
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Game centre authentication support.
2 participants