Improve WebSocketServer Error Handling #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #6173 Prevents an unhandled server rejection. Includes an example for LiveQuery test and closing the proper connections. Improve live query monitoring
Codecov Report
@@ Coverage Diff @@
## master #6230 +/- ##
==========================================
+ Coverage 93.86% 93.95% +0.09%
==========================================
Files 167 167
Lines 11302 11306 +4
==========================================
+ Hits 10609 10623 +14
+ Misses 693 683 -10
Continue to review full report at Codecov.
|
|
@acinader How does this look? |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Improve WebSocketServer Error Handling Closes: parse-community#6173 Prevents an unhandled server rejection. Includes an example for LiveQuery test and closing the proper connections. Improve live query monitoring * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6173
Prevents an unhandled promise rejection and crashing.
Includes an example for LiveQuery test and closing the proper connections. Since they didn’t exist.
Improve live query monitoring