Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Non null ACL #6249

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Dec 1, 2019

For global security comprehension on GraphQL we should avoid ACL: null, when ACL do not exist on Parse Object return public readable/writable.

@Moumouls Moumouls requested a review from davimacedo December 1, 2019 21:59
@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #6249 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6249      +/-   ##
==========================================
- Coverage   93.98%   93.94%   -0.05%     
==========================================
  Files         168      168              
  Lines       11346    11347       +1     
==========================================
- Hits        10664    10660       -4     
- Misses        682      687       +5
Impacted Files Coverage Δ
src/GraphQL/loaders/parseClassTypes.js 94.47% <ø> (ø) ⬆️
src/GraphQL/transformers/outputType.js 81.81% <0%> (ø) ⬆️
src/GraphQL/loaders/defaultGraphQLTypes.js 96.67% <100%> (+0.01%) ⬆️
src/GraphQL/helpers/objectsQueries.js 98.03% <100%> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.74% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.58% <0%> (-0.5%) ⬇️
src/Routers/PushRouter.js 96.55% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4435154...e075812. Read the comment docs.

@davimacedo davimacedo merged commit 6245996 into parse-community:master Dec 2, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants