Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL classConfig query alias #6257

Merged
merged 2 commits into from
Dec 4, 2019
Merged

GraphQL classConfig query alias #6257

merged 2 commits into from
Dec 4, 2019

Conversation

BufferUnderflower
Copy link
Contributor

Solves #6218

Adds getAlias and findAlias for GraphQL classConfig.
e.g.

{
...
classConfigs: [
          {
            className: 'Data',
            query: {
              get: true,
              getAlias: 'precious_data',
              find: true,
              findAlias: 'data_results',
            },
          },
]}

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #6257 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6257      +/-   ##
==========================================
- Coverage   93.96%   93.93%   -0.04%     
==========================================
  Files         169      169              
  Lines       11529    11536       +7     
==========================================
+ Hits        10833    10836       +3     
- Misses        696      700       +4
Impacted Files Coverage Δ
src/GraphQL/loaders/parseClassQueries.js 97.95% <100%> (+0.08%) ⬆️
src/Controllers/ParseGraphQLController.js 95.71% <100%> (+0.15%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.74% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.42% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcc5fd...8dea94c. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. Are you willed to do the same also for mutations? :)

@davimacedo davimacedo merged commit 188f033 into parse-community:master Dec 4, 2019
@BufferUnderflower BufferUnderflower deleted the gql-query-alias branch December 4, 2019 00:27
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants