Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against Postgres 11 #6260

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Run tests against Postgres 11 #6260

merged 4 commits into from
Dec 4, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2019 •
edited
Loading

Codecov Report

Merging #6260 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6260      +/-   ##
==========================================
- Coverage   93.99%   93.96%   -0.04%     
==========================================
  Files         169      169              
  Lines       11544    11544              
==========================================
- Hits        10851    10847       -4     
- Misses        693      697       +4
Impacted Files Coverage Δ
src/Routers/PushRouter.js 93.1% <0%> (-3.45%) ⬇️
src/Controllers/SchemaController.js 96.42% <0%> (-0.22%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db040b...873e834. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2019 •
edited
Loading

@davimacedo I think this is good, should help with the flaky tests. I re-ran travis a few times

@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2019

@vitaly-t Using Ubuntu Xenial for Travis build adds more disk space and PG 11 has better WAL (write ahead log) improvements.

davimacedo
davimacedo approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit afe49cb into master Dec 4, 2019
@dplewis dplewis deleted the pg-11 branch December 4, 2019 18:24
@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2019

For future reference, I think wal_level defaults to minimal in PG 11, I'm not sure but we could add the following to travis.yml in the future if we run into that disk space issue again.

- sudo sed -i 's/wal_level = replica/wal_level = minimal/' /etc/postgresql/11/main/postgresql.conf

@vitaly-t
Copy link
Contributor

vitaly-t commented Dec 4, 2019

@dplewis Interesting! I've been looking for some help with PG v11 here - vitaly-t/pg-promise#670

But no luck... If you can make time and help me update pg-promise to use PG v11, that would be awesome!!!

@dplewis
Copy link
Member Author

dplewis commented Dec 4, 2019

No problem!

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis
Run tests against Postgres 11 (parse-community#6260)
87f0196 
* Run tests against Postgres 11

* postgis package

* use xenial travis image

* port 5432
@snyk-bot snyk-bot mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@acinader acinader Awaiting requested review from acinader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @vitaly-t @davimacedo