Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added volumes to Docker command #6356

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Added volumes to Docker command #6356

merged 1 commit into from
Jan 23, 2020

Conversation

githubsaturn
Copy link
Contributor

@githubsaturn githubsaturn commented Jan 22, 2020

Added volumes to Docker command
Fixes #6353

Added volumes to Docker command
#6353
@githubsaturn
Copy link
Contributor Author

githubsaturn commented Jan 22, 2020

Also, please update the docs at Docker Hub. Unfortunately Docker Hub doesn't automatically track the GitHub repo to reflect README changes and it has be manually updated by the maintainers.

Alternatively, even better option is to just leave a link in Docker Hub pointing to GitHub repo instead of having the full documentation replicated there. This has been the common practice lately in order to avoid having out of sync README on DockerHub.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #6356 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6356      +/-   ##
==========================================
- Coverage   93.84%   93.81%   -0.04%     
==========================================
  Files         169      169              
  Lines       11626    11626              
==========================================
- Hits        10911    10907       -4     
- Misses        715      719       +4
Impacted Files Coverage Δ
src/Routers/PushRouter.js 93.1% <0%> (-3.45%) ⬇️
src/RestWrite.js 93.46% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed6535...6ab326e. Read the comment docs.

@davimacedo davimacedo merged commit 4ab3665 into parse-community:master Jan 23, 2020
@davimacedo
Copy link
Member

@acinader do you have access to the docker hub?

@acinader
Copy link
Contributor

@davimacedo I do!

@githubsaturn I followed your suggestion

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Documentation Issue
3 participants