Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 4.0 Release #6412

Merged
merged 13 commits into from
Feb 28, 2020
Merged

Prepare for 4.0 Release #6412

merged 13 commits into from
Feb 28, 2020

Conversation

acinader
Copy link
Contributor

No description provided.

@acinader acinader requested a review from TomWFox February 15, 2020 00:55
dplewis
dplewis previously approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomWFox you beat me to it.

TomWFox
TomWFox approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there’s some nice features and fixes in this for a small release!

@dplewis
Copy link
Member

dplewis commented Feb 15, 2020

Oh what about the release build

@dplewis
Copy link
Member

dplewis commented Feb 15, 2020

We didn’t fix travis

@codecov
Copy link

codecov bot commented Feb 15, 2020 •
edited
Loading

Codecov Report

Merging #6412 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6412      +/-   ##
==========================================
- Coverage   93.95%   93.95%   -0.01%     
==========================================
  Files         169      169              
  Lines       11811    11794      -17     
==========================================
- Hits        11097    11081      -16     
+ Misses        714      713       -1
Impacted Files Coverage Δ
src/Controllers/index.js 96.66% <ø> (ø) ⬆️
src/Config.js 89.6% <ø> (ø) ⬆️
src/Options/index.js 100% <ø> (ø) ⬆️
src/Options/Definitions.js 100% <ø> (ø) ⬆️
src/Controllers/DatabaseController.js 95.19% <100%> (-0.13%) ⬇️
src/RestWrite.js 93.81% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52adc30...8c2db1b. Read the comment docs.

@acinader acinader requested review from TomWFox and dplewis February 24, 2020 17:46
TomWFox
TomWFox previously approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, I just removed a few full stops to make it more consistent.

@dplewis
Copy link
Member

dplewis commented Feb 24, 2020

@davimacedo found out that this release would require Mongo DB 3.6 as a minimum because of recent collation support.

@acinader
Copy link
Contributor Author

do we know if parse fails to start with < mongo 3.6? I think we should change the minimum to 3.6 then. Should I make change the version to 4.0.0 instead of 3.11.0? I'll need to change the docs too.

@davimacedo nice catch, any thoughts here?

@davimacedo
Copy link
Member

I'd go with 4.0 since MongoDB 3.2 does not work anymore.

@dplewis
Copy link
Member

dplewis commented Feb 25, 2020 •
edited
Loading

I agree and just so happens that Mongo 3.4 reached end of life January 2020.

https://www.mongodb.com/support-policy

We can start adding 3.6 features as well.

@acinader
Copy link
Contributor Author

sounds good.

i'll try and get that into this pr in the next day. thanks guys!!

@acinader acinader changed the title Prepare for 3.11.0 Release Prepare for 4.0 Release Feb 28, 2020
@acinader acinader dismissed stale reviews from TomWFox and dplewis February 28, 2020 17:42

changing pr

@acinader
Copy link
Contributor Author

i think this is ready.

TomWFox
TomWFox approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 final review? 😉

@acinader acinader merged commit 4291f2b into master Feb 28, 2020
@acinader acinader deleted the prepare-3.11 branch February 28, 2020 23:22
@TomWFox TomWFox added the release label Mar 1, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@acinader @TomWFox
Prepare for 4.0 Release (parse-community#6412)
b0ca97f 
* Preparee for 3.11.0 Release

* Little fixes

* add in newly merge pr's into the changelog.

* Remove inconsistent full stops

* bump version to 4.0

* update changelog for v 4.0

* a touch of wordmsithery.

* Nits

Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWFox TomWFox TomWFox approved these changes

@dplewis dplewis Awaiting requested review from dplewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acinader @dplewis @davimacedo @TomWFox