Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraphQL Error Condition on mutation #6431

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix GraphQL Error Condition on mutation #6431

merged 1 commit into from
Feb 21, 2020

Conversation

Moumouls
Copy link
Member

No description provided.

@Moumouls Moumouls added the type:bug Impaired feature or lacking behavior that is likely assumed label Feb 21, 2020
@Moumouls Moumouls requested a review from davimacedo February 21, 2020 09:46
@Moumouls Moumouls self-assigned this Feb 21, 2020
davimacedo
davimacedo approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM!

@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #6431 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6431      +/-   ##
==========================================
- Coverage   93.96%   93.93%   -0.04%     
==========================================
  Files         169      169              
  Lines       11787    11787              
==========================================
- Hits        11076    11072       -4     
- Misses        711      715       +4
Impacted Files Coverage Δ
src/GraphQL/transformers/mutation.js 96.59% <100%> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.79% <0%> (-0.68%) ⬇️
src/RestWrite.js 93.48% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292bdb7...d83edb8. Read the comment docs.

@davimacedo davimacedo merged commit cbef90d into parse-community:master Feb 21, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@Moumouls
fix (parse-community#6431)
d85a291
@mtrezza mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

Assignees

@Moumouls Moumouls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moumouls @davimacedo @mtrezza