-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not allow to protect default fields #6439
Do not allow to protect default fields #6439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6439 +/- ##
==========================================
- Coverage 93.96% 93.39% -0.57%
==========================================
Files 169 169
Lines 11811 11811
==========================================
- Hits 11098 11031 -67
- Misses 713 780 +67
Continue to review full report at Codecov.
|
Reasonable, I was working on dashboard and noticed 'field does not exist' error when tried to protect some of default fields. So another solution would be to just fine tune that message and agree to disallow protecting default fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. LGTM!
* consider default columns * disallow protecting default fields
No description provided.