Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix postgres error in travis #6490

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Attempt to fix postgres error in travis #6490

merged 5 commits into from
Mar 11, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 11, 2020

fixing postgres issue in CL to address #6374

testing error to see what happens...
Attempting to resolve postgres in CL by installing postgis via sudo instead of through apt/packages
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #6490 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6490      +/-   ##
==========================================
+ Coverage   93.93%   93.96%   +0.02%     
==========================================
  Files         169      169              
  Lines       11808    11808              
==========================================
+ Hits        11092    11095       +3     
+ Misses        716      713       -3     
Impacted Files Coverage Δ
src/RestWrite.js 93.64% <0.00%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.46% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4a2c2...0dc0cf5. Read the comment docs.

Removed extra lines of postgres that were under "services" and "addons". I believe the "postgresql" line under "services" was installing the default of 9.6 and "addons" was installing postgres 11. My guess is the fail was occurring due to 9.6 being called sometimes and it never had postgis installed. If this is true, the solution is to only install one version of postgres, which is version 11 with postgis 2.5.
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm . let's see how it does....

@acinader acinader merged commit 555ae21 into parse-community:master Mar 11, 2020
@cbaker6 cbaker6 changed the title Update .travis.yml Attempt to fix postgres error in travis Mar 14, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…res once

Update .travis.yml (parse-community#6490)

* Update .travis.yml

testing error to see what happens...

* Update .travis.yml

Attempting to resolve postgres in CL by installing postgis via sudo instead of through apt/packages

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

Removed extra lines of postgres that were under "services" and "addons". I believe the "postgresql" line under "services" was installing the default of 9.6 and "addons" was installing postgres 11. My guess is the fail was occurring due to 9.6 being called sometimes and it never had postgis installed. If this is true, the solution is to only install one version of postgres, which is version 11 with postgis 2.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants