Switch ACL to Relay Global Id #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moumouls
added
type:bug
Codecov Report
@@ Coverage Diff @@
## master #6495 +/- ##
===========================================
- Coverage 93.92% 83.77% -10.16%
===========================================
Files 169 169
Lines 11808 11812 +4
===========================================
- Hits 11091 9895 -1196
- Misses 717 1917 +1200
Continue to review full report at Codecov.
|
davimacedo
requested changes
Mar 11, 2020
| @@ -553,7 +554,7 @@ const ACL = new GraphQLObjectType({ | |||
| Object.keys(p).forEach(rule => { | |||
| if (rule !== '*' && rule.indexOf('role:') !== 0) { | |||
| users.push({ | |||
| userId: rule, | |||
| userId: toGlobalId('_User', rule), | |||
There was a problem hiding this comment.
Can we make to work with either Relay global id or Parse object id?
There was a problem hiding this comment.
Its the output type, we should return only the RelayId, otherwise it would be hard in a near further to get off objectId
There was a problem hiding this comment.
Sorry. My bad. You're right.
| @@ -99,6 +99,10 @@ const transformers = { | |||
| } | |||
| if (value.users) { | |||
| value.users.forEach(rule => { | |||
| const globalIdObject = fromGlobalId(rule.userId); | |||
There was a problem hiding this comment.
Like here. I think here it is working with both ids.
mtrezza
removed
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.