Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb to the latest version 🚀 #6497

Merged
2 commits merged into from
Mar 12, 2020
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 11, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency mongodb was updated from 3.5.4 to 3.5.5.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: mbroadst
License: Apache-2.0

Release Notes for v3.5.5

The MongoDB Node.js team is pleased to announce version 3.5.5 of the driver

Release Highlights

Regression in hasNext when using a cursor with a limit

@peterbroadhurst helped point out a regression introduced in v3.5.4 where using hasNext
on a cusor with a limit would not return the full set of results.

Ignored topology updates cause servers to fall out of latency window

A change introduced across all MongoDB drivers, and in particular v3.5.0 of the Node.js
driver, attempted to prevent needless duplicate topologyDescriptionChanged topology events
by introducing a ServerDescription equality operator. Since equality does not take the
lastUpdateTime and lastWriteDate fields of an ismaster into account, the driver could
eventually consider servers non-suitable for server selection, since they would fall out
of the latency window.
All updates are considered viable for topology updates now, and only event emission is
gated by ServerDescription equality.

Memory leaks with Node.js v12+

The legacy topology types (in particular if you were connected to a replic set) used a
custom Timeout class to wrap a timer. Unfortunately, the class depended on an undocumented,
private variable _called, which was removed in Node.js v12. This would lead to the driver
thinking the timeout never occurred, and therefore never releasing the object for garbage
collection. We recommend users of the legacy topology types immediately update to this
version of the driver, or use the Unified Topology which is unaffected by this bug.

TypeError: Cannot read property 'Symbol(cancelled)' of undefined

@erfanium and @Paic helped us identify an issue in rare failover events where multiple
requests to process the server selection queue would result in an attempted property
access of an undefined variable.

promiseLibrary not respected by newly introduced maybePromise helper

@TobyEalden pointed out that an internal refactor to use a helper to optionally
return a Promise for top level API methods was not, in fact, using a custom
promise library if one was provided!

Thanks very much to all the community members who contributed to this release!

Release Notes

Bug

  • [NODE-2460] - Memory Leak with ReplSet and NodeJS v12
  • [NODE-2472] - TypeError on server available with useUnifiedTopology: true
  • [NODE-2474] - Server_Description update with lastUpdateTime / lastWriteDate fields is ignored in topology
  • [NODE-2480] - TypeError after reconnecting
  • [NODE-2483] - Regression using hasNext on cursor with limit
  • [NODE-2490] - promiseLibrary option is not honoured
Commits

The new version differs by 11 commits.

  • d7ac176 chore(release): 3.5.5
  • f69f51c fix: multiple concurrent attempts to process the queue may fail
  • cde11ec fix: pass optional promise lib to maybePromise
  • 0c36a32 NODE-2474: update equal server description (#2260)
  • 6b3b64d test: ensure mock server is setup before continuing with tests
  • 6238c84 fix: correctly use template string for connection string error message
  • 44097c2 test: use a reduced minHeartbeatFrequencyMS for spec test runner
  • ef04d00 fix(cursor): hasNext consumes documents on cursor with limit
  • b72fefe docs: update community links to use MongoDB Community forums
  • e7dd608 docs: fix typo and formatting of bulletted lists
  • 3ddaa3e fix: don't depend on private node api for Timeout wrapper

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label Mar 11, 2020
@ghost ghost merged commit e8bbde4 into master Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #6497 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6497      +/-   ##
==========================================
+ Coverage   93.98%   94.02%   +0.03%     
==========================================
  Files         169      169              
  Lines       11825    11825              
==========================================
+ Hits        11114    11118       +4     
+ Misses        711      707       -4
Impacted Files Coverage Δ
src/RestWrite.js 93.97% <0%> (+0.16%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.46% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0e485...67ece0d. Read the comment docs.

@greenkeeper greenkeeper bot deleted the greenkeeper/mongodb-3.5.5 branch March 12, 2020 01:21
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* fix(package): update mongodb to version 3.5.5

* chore(package): update lockfile package-lock.json

Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants