Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort pattern aggregations fix postgres #6510

Closed
wants to merge 15 commits into from
Closed

Sort pattern aggregations fix postgres #6510

wants to merge 15 commits into from

Conversation

srameshr
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #6510 into master will increase coverage by 0.04%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6510      +/-   ##
==========================================
+ Coverage   93.96%   94.01%   +0.04%     
==========================================
  Files         169      169              
  Lines       11801    11829      +28     
==========================================
+ Hits        11089    11121      +32     
+ Misses        712      708       -4
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.75% <93.75%> (+0.02%) ⬆️
src/GraphQL/ParseGraphQLSchema.js 97.4% <0%> (+0.15%) ⬆️
src/Adapters/Auth/apple.js 100% <0%> (+12.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f695459...7a12fd3. Read the comment docs.

…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
@srameshr
Copy link
Contributor Author

@dplewis @davimacedo
Can you please review this PR?

…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
@srameshr
Copy link
Contributor Author

@dplewis @davimacedo
Can you look into this? There is an error that is thrown during test cases init. Works fine locally

0.97s$ nvm install $NODE_VERSION
before_install.2
0.43s$ nvm use $NODE_VERSION
before_install.3
1.03s$ npm install -g greenkeeper-lockfile@1
before_install.4
0.01s$ sudo sed -i 's/port = 5433/port = 5432/' /etc/postgresql/11/main/postgresql.conf
before_install.5
0.01s$ sudo cp /etc/postgresql/{10,11}/main/pg_hba.conf
before_install.6
0.16s$ sudo service postgresql stop
before_install.7
2.54s$ sudo service postgresql start 11
install.npm
18.66s$ npm ci 
before_script.1
1.30s$ node -e 'require("./lib/index.js")'
before_script.2
0.22s$ psql -c 'create database parse_server_postgres_adapter_test_database;' -U postgres
0.17s$ psql -c 'CREATE EXTENSION postgis;' -U postgres -d parse_server_postgres_adapter_test_database
ERROR:  could not access file "$libdir/postgis-2.4": No such file or directory
The command "psql -c 'CREATE EXTENSION postgis;' -U postgres -d parse_server_postgres_adapter_test_database" failed and exited with 1 during .

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 17, 2020

@srameshr the error is will hopefully be fixed with #6505

@srameshr
Copy link
Contributor Author

@cbaker6 That PR seems to be open since the last two days. Please notify me when its merged.

@srameshr
Copy link
Contributor Author

@cbaker6 Any updates on this?

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 20, 2020

@srameshr the main branch has the fix. Let me know if you see the Postgres error in the rest of your tests

@srameshr
Copy link
Contributor Author

@cbaker6 Yes, I still get this error. I synced my branch with main master branch.

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 20, 2020

@srameshr from what I see it says your branch is 14 commits behind the master and I can't see that you ran the test again.

…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
…rameshr/parse-server into sort-pattern-aggregations-fix-postgres
@srameshr
Copy link
Contributor Author

@cbaker6 @dplewis @davimacedo There are some test cases failing which is totally unrelated to this commit. Can someone take a look at that?

@cbaker6
Copy link
Contributor

cbaker6 commented Mar 20, 2020

@srameshr can run the test a couple of more times by committing? I would like to see if the same errors you just got are reoccurring

@srameshr
Copy link
Contributor Author

@cbaker6
I tried pushing it. It's not triggering the build again. Can you run it manually?

@dplewis
Copy link
Member

dplewis commented Mar 20, 2020

@srameshr I just restarted the build. I'll keep an eye on it

@srameshr
Copy link
Contributor Author

@dplewis @cbaker6
It fails again.

 1) PushController properly creates _PushStatus Message: Expected 'pending' to be 'running'.

@dplewis
Copy link
Member

dplewis commented Mar 20, 2020

Thats a flaky test, nothing to do with this PR. It's really difficult to replicate locally otherwise it would be fixed.

return query.aggregate(pipeline);
})
.then(results => {
expect(results.length).toEqual(5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand this expect to show group by multiple columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is messed up in my repo. Il create a new PR

@srameshr
Copy link
Contributor Author

@dplewis
#6522

@dplewis
Copy link
Member

dplewis commented Apr 6, 2020

Closing via #6522

@dplewis dplewis closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants