Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep release 4.2 #6560

Merged
merged 11 commits into from
Apr 3, 2020
Merged

Prep release 4.2 #6560

merged 11 commits into from
Apr 3, 2020

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Apr 2, 2020

No description provided.

@acinader acinader requested a review from TomWFox April 2, 2020 21:04
@TomWFox
Copy link
Contributor

TomWFox commented Apr 2, 2020

I was going to start a petition to switch to a changelog style like the JS SDK one with headings for new features, improvements, fixes, security.

I find it much more readable and the improvement would be more noticeable now the parse-server releases are consistently big.

Thoughts?

@TomWFox TomWFox added the release label Apr 2, 2020
@acinader
Copy link
Contributor Author

acinader commented Apr 2, 2020

  1. this one is already done, so i'd like to start with the next
  2. i'd like something automated. just inserting a link to the github commit list would be fine with me and then if there was something noteworthy, it could be added ad-hoc.

3.10.0...4.0.0

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #6560 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6560   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files         169      169           
  Lines       11959    11959           
=======================================
  Hits        11227    11227           
  Misses        732      732           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcba8e0...28c8205. Read the comment docs.

@TomWFox
Copy link
Contributor

TomWFox commented Apr 2, 2020

  1. that's cool, just wanted to open the discussion

  2. I agree, I've been looking into different options for automation. I suppose it's about quickly showing to the dev what has changed (with that in mind I probably wouldn't include details about changes to unit tests - not to discredit that work!!). Having said that, because we use squash & merge the commit list generally isn't too bad 🤷‍♂️

  3. If we could automate it in a way that was fairly hassle free would it not be nice to keep doing it for those that find a changelog useful?

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dplewis
Copy link
Member

dplewis commented Apr 2, 2020

@acinader A PR was merged. Can you update from master and include it in the release?

#6344

@acinader
Copy link
Contributor Author

acinader commented Apr 2, 2020

Will do @dplewis

@acinader
Copy link
Contributor Author

acinader commented Apr 2, 2020

@TomWFox could you please give the changelog a quick look again....

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acinader have you got a sticky space bar?? 😉

@cbaker6
Copy link
Contributor

cbaker6 commented Apr 3, 2020

@acinader do you think #6376 can be added? @dplewis added some test cases for it.

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants