Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql tools v5 #6611

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Conversation

yaacovCR
Copy link
Contributor

No description provided.

@Moumouls
Copy link
Member

I'll check this asap tomorrow (I'm in EU)

Copy link
Member

@Moumouls Moumouls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yaacovCR for your work on graphql tools repo !

@Moumouls
Copy link
Member

@davimacedo seems to have an issue with postrgres can we merge ?

@davimacedo
Copy link
Member

Great job @yaacovCR I'm running the Postgres test again and I will merge.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #6611 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
- Coverage   94.03%   93.95%   -0.09%     
==========================================
  Files         169      169              
  Lines       11848    12055     +207     
==========================================
+ Hits        11141    11326     +185     
- Misses        707      729      +22     
Impacted Files Coverage Δ
src/GraphQL/helpers/objectsQueries.js 90.83% <100.00%> (-0.53%) ⬇️
src/GraphQL/loaders/parseClassQueries.js 97.95% <100.00%> (+0.04%) ⬆️
src/GraphQL/loaders/parseClassTypes.js 94.23% <100.00%> (+0.07%) ⬆️
src/Routers/FilesRouter.js 84.82% <0.00%> (-7.91%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.33% <0.00%> (-0.41%) ⬇️
src/triggers.js 92.80% <0.00%> (-0.15%) ⬇️
src/Adapters/Files/FilesAdapter.js 100.00% <0.00%> (ø)
src/Controllers/FilesController.js 93.61% <0.00%> (ø)
src/Controllers/DatabaseController.js 95.19% <0.00%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.52% <0.00%> (+0.05%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bda61...c6d83dd. Read the comment docs.

@davimacedo davimacedo merged commit a6300a2 into parse-community:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants