Skip to content

#6589 catch JSON.parse and return 403 properly #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

sunshineo
Copy link
Contributor

@sunshineo sunshineo commented Apr 15, 2020

real change is very small, most are lint changes done by husky on the git pre-commit hook, not set by me #6589

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #6614 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6614      +/-   ##
==========================================
+ Coverage   93.90%   94.00%   +0.10%     
==========================================
  Files         169      169              
  Lines       11970    11972       +2     
==========================================
+ Hits        11240    11254      +14     
+ Misses        730      718      -12     
Impacted Files Coverage Δ
src/middlewares.js 97.31% <100.00%> (+0.02%) ⬆️
src/Controllers/SchemaController.js 97.11% <0.00%> (+0.19%) ⬆️
src/Controllers/DatabaseController.js 95.51% <0.00%> (+0.32%) ⬆️
src/RestWrite.js 93.97% <0.00%> (+0.32%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.80% <0.00%> (+0.46%) ⬆️
src/Routers/UsersRouter.js 94.96% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08b930...b8685ac. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit a5ef0be into parse-community:master Apr 15, 2020
@sunshineo sunshineo deleted the issue-6589 branch April 19, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants