Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve a test case (related to #6590) #6629

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sunshineo
Copy link
Contributor

@sunshineo sunshineo commented Apr 19, 2020

  1. do not need to create a new server, just use the reconfigureServer tool
  2. use async await

related to #6590

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #6629 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6629      +/-   ##
==========================================
- Coverage   93.91%   93.88%   -0.03%     
==========================================
  Files         169      169              
  Lines       11972    11972              
==========================================
- Hits        11243    11240       -3     
- Misses        729      732       +3     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.85% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccd6ce...ea29542. Read the comment docs.

1. do not need to create a new server, use the reconfigureServer tool
3. use async await
@sunshineo sunshineo changed the title fix a test case (related to #6590) improve a test case (related to #6590) Apr 19, 2020
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 9d8955c into parse-community:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants