Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix explain on user class #6650

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 26, 2020

fixes #6647

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #6650 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6650      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.04%     
==========================================
  Files         169      169              
  Lines       11991    11991              
==========================================
- Hits        11261    11257       -4     
- Misses        730      734       +4     
Impacted Files Coverage Δ
src/RestQuery.js 95.47% <100.00%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.85% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.48% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71147eb...ca3725a. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Apr 28, 2020

@acinader ready for review

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acinader acinader merged commit 2b72233 into parse-community:master Apr 28, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Apr 28, 2020

Thanks!

@mess-lelouch
Copy link
Contributor

Thanks for the fix! Any chance this change will make it to a hotfix soon?

@mtrezza
Copy link
Member Author

mtrezza commented May 7, 2020

@mess-lelouch The change will be part of the (regular) next release. Expect it to happen soon though, as it‘s been a month since the last release and the (informal) release cycle is somewhat monthly.

If you need it urgently, you can fork parse server and deploy a commit of the master branch that passes all tests.

Sent with GitHawk

@mess-lelouch
Copy link
Contributor

@mtrezza got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain() does not work in Cloud Code
3 participants