-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix context for cascade-saving and saving existing object #6735
fix context for cascade-saving and saving existing object #6735
Conversation
Thanks for bumping the SDK, I was waiting for the PR from Synx. Can you run npm install to update the package lock? |
Yes, it's already running. I gotta head out now, if CI fails I'll take a look at it in a couple of hours. |
It looks good to me, can you remove the comments that are self documenting? |
You mean these |
Codecov Report
@@ Coverage Diff @@
## master #6735 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 169 169
Lines 12047 12048 +1
==========================================
Hits 11311 11311
- Misses 736 737 +1
Continue to review full report at Codecov.
|
Looks like a false positive in coverage, ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes issues with
context
when saving objects:context
is set when saving an existing object:context
is lost when cascade-saving objects so thatcontext
is inherited by child objects (obj2
in this example):Requires:
closes #6736