Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed gaze from dev dependencies and removed not working dev script #6745

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

vince1995
Copy link
Contributor

@vince1995 vince1995 commented Jun 23, 2020

There was a dev script added in 18f9e5340563833cebab333ee6205d5c8ac6413a where gaze was added to the dev dependencies and a script named dev was created in the package.json.

The dev script was removed in 021a12f648d53b30392f4ca3d4e3a78bebab1f54 but the package.json wasn't cleaned up. Instead gaze was updated several times. 🤔

This PR removes the gaze package from the dev deps and removes the dev script from the package.json.

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #6745 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6745      +/-   ##
==========================================
- Coverage   93.91%   93.88%   -0.03%     
==========================================
  Files         169      169              
  Lines       12029    12029              
==========================================
- Hits        11297    11294       -3     
- Misses        732      735       +3     
Impacted Files Coverage Δ
src/RestWrite.js 93.51% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a9c70...74f36e0. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Jun 24, 2020

Good catch! Can you update package-lock.json?

@vince1995
Copy link
Contributor Author

Done. 👍

@dplewis dplewis merged commit d5ac0f7 into parse-community:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants