Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom gql schema function to ParseServer#start options #6762

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

lucatk
Copy link
Contributor

@lucatk lucatk commented Jun 29, 2020

This simple typecheck seems to be missing, which results in not being able to pass a custom "merging" function to the ParseGraphQLServer instance through ParseServer#start.
This section requires the passed custom graphql schema to be a function, however the line this PR alters prevents the usage of that section in its current revision.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #6762 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6762      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.05%     
==========================================
  Files         169      169              
  Lines       12029    12484     +455     
==========================================
+ Hits        11297    11719     +422     
- Misses        732      765      +33     
Impacted Files Coverage Δ
src/ParseServer.js 89.47% <100.00%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.85% <0.00%> (-0.67%) ⬇️
src/Controllers/index.js 96.61% <0.00%> (-0.06%) ⬇️
src/Options/Definitions.js 100.00% <0.00%> (ø)
src/RestWrite.js 94.19% <0.00%> (+0.18%) ⬆️
src/middlewares.js 97.54% <0.00%> (+0.23%) ⬆️
src/batch.js 93.10% <0.00%> (+1.26%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 75.21% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ac0f7...92a6ab3. Read the comment docs.

@dplewis dplewis merged commit 4437ea7 into parse-community:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants