Fix for JS SDK needing a key #680
Conversation
src/index.js
Outdated
| collectionPrefix = '', | ||
| clientKey = '', | ||
| javascriptKey = randomString(20), | ||
| javascriptKey = '', |
There was a problem hiding this comment.
why not 'unused' there?
There was a problem hiding this comment.
because if the server believes it has any client-type key set, every request to the server requires a valid client key (js, client, dotnet, rest).
There was a problem hiding this comment.
it's still set to '' we don't check for key lengths. I'll test that in the test repo
|
|
||
| // Initialize the node client SDK automatically | ||
| Parse.initialize(appId, javascriptKey, masterKey); | ||
| Parse.initialize(appId, javascriptKey || 'unused', masterKey); |
There was a problem hiding this comment.
javascript key is never undefined here as it's defaulted to ''
There was a problem hiding this comment.
ok, how about now, with the defaults removed...
There was a problem hiding this comment.
That should do, but not sure why @drew-gross added the default strings there?
There was a problem hiding this comment.
That was just me mimicking the previous behaviour when updating this function to ES6 style
|
@gfosco updated the pull request. |
|
@gfosco that will reintroduce the bug. if any key is set... |
Alternative to #652. This doesn't cause client keys to be required on all requests.