-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skipWithMasterKey on Built-In Validator #6972
Conversation
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #6972 +/- ##
==========================================
- Coverage 93.88% 93.80% -0.08%
==========================================
Files 169 169
Lines 12353 12402 +49
==========================================
+ Hits 11597 11634 +37
- Misses 756 768 +12
Continue to review full report at Codecov.
|
What do you think about |
Changes made @davimacedo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM!
Sorry for the overwhelming amount of content posted.
Small improvement to the Validator, related to #6968.
I find myself often writing this often in cloud functions:
This PR allows for triggers to be skipped if a masterKey is provided, and if
skipWithMasterKey
is true:Also a small improvement to the beforeFind trigger: Throwing a string will return error code 141 instead of error code 1.
Thank you as always for your time!