Rename ExportAdapter to DatabaseController, start splitting Mongo specific logic. #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.database.controller
branch
from
d18e8b5
to
b70c9bf
Compare
|
@nlutsenko updated the pull request. |
|
|
||
| // options can contain: | ||
| // collectionPrefix: the string to put in front of every collection name. | ||
| function ExportAdapter(mongoURI, options = {}) { | ||
| this.mongoURI = mongoURI; | ||
| function DatabaseController(adapter, { collectionPrefix } = {}) { |
There was a problem hiding this comment.
You may wanna use AdaptableController here as it ensures the prototype of the adapter matches the expected adapter prototype
There was a problem hiding this comment.
Yup, a little bit later tho.
|
One optional nit, otherwise looks good to me. The cleanup around |
nlutsenko
force-pushed
the
nlutsenko.database.controller
branch
from
b70c9bf
to
eb89283
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 29, 2016
Rename ExportAdapter to DatabaseController, start splitting Mongo specific logic.
|
more rebase madness for #627 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first PR that kickstarts the effort to move use away from Mongo-specific storage, and implement Postgres.
After playing with 3-5 different approaches, turns out that the best one is to reuse all the logic that we have right now in ExportAdapter, and then decouple piece by piece away from it. This still guarantees that we are not duplicating logic/names/classes/functions, but are moving into storage-independent future.
Now back to this PR:
Turns out that by doing all of this - we also can kill the requirement for calling
connect()on the DatabaseController before any operation.cc @lacker, @gfosco