Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent casing for afterLiveQueryEvent #7023

Merged

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 24, 2020

Closes #7022

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #7023 (83a9fa9) into master (d4f405d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7023      +/-   ##
==========================================
- Coverage   93.85%   93.79%   -0.06%     
==========================================
  Files         169      169              
  Lines       12415    12415              
==========================================
- Hits        11652    11645       -7     
- Misses        763      770       +7     
Impacted Files Coverage Δ
src/LiveQuery/ParseLiveQueryServer.js 94.92% <100.00%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (-0.67%) ⬇️
src/Controllers/SchemaController.js 96.92% <0.00%> (-0.20%) ⬇️
src/RestWrite.js 93.67% <0.00%> (-0.17%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.87% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f405d...83a9fa9. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. @mtrezza any additional comment?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @dblythy thanks for the fast fix!

@davimacedo davimacedo merged commit 0bf2e84 into parse-community:master Nov 24, 2020
@dblythy dblythy deleted the lowercaseAfterLiveQueryEvent branch November 25, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between afterLiveQueryEvent "type" and SDK
3 participants