Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Remove viewer from logout mutation #7029

Merged

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Nov 29, 2020

I also updated mongo db runner to direct github master branch repo since 4.8.0 (published in Jan 2020) do not work on Node 14/15. We need to wait for their new package release. (https://github.com/mongodb-js/runner)

@Moumouls Moumouls added type:bug Impaired feature or lacking behavior that is likely assumed 🧬 enhancement labels Nov 29, 2020
@Moumouls Moumouls requested a review from davimacedo November 29, 2020 12:00
@Moumouls Moumouls self-assigned this Nov 29, 2020
@davimacedo
Copy link
Member

Thanks for the PR. It looks good to me. But Travis is not working now and we will have to wait it to check the tests. About the mongodb-runner @dplewis do you have any thoughts?

@Moumouls
Copy link
Member Author

yeah i see that travis was not launched, and also what do you think about switching asap from Travis to Github action ?

@davimacedo
Copy link
Member

That's an idea. Do you have experience with GitHub actions?

@Moumouls
Copy link
Member Author

Moumouls commented Dec 1, 2020

That's an idea. Do you have experience with GitHub actions?

Yes, i currently use GitHub action for many projects :), I think the migration could be easy, I can give a try asap !

@davimacedo
Copy link
Member

davimacedo commented Dec 1, 2020

I am on it right now. I will push what I've done so far so you can double check.

@davimacedo
Copy link
Member

@mtrezza mtrezza removed type:bug Impaired feature or lacking behavior that is likely assumed 🧬 enhancement labels Dec 3, 2020
@mtrezza
Copy link
Member

mtrezza commented Dec 3, 2020

Note: Labels removed to comply with #6984. Labels apply to issues only. We'll add a bot for this. Any suggestion for PR labels please discuss in the referenced thread.

@Moumouls
Copy link
Member Author

Moumouls commented Dec 3, 2020

sorry @mtrezza i should check the new label policy

@mtrezza
Copy link
Member

mtrezza commented Dec 3, 2020

@Moumouls No worries, it's still experimental and we're figuring things out as we go. Instructions on label usage will be improved to be easier readable once we have figured this out. If you have any suggestions please feel free to post in the referenced thread 🙂

@Moumouls
Copy link
Member Author

Moumouls commented Dec 7, 2020

@davimacedo LGTY ? 😄

@davimacedo davimacedo merged commit b398894 into parse-community:master Dec 7, 2020
@dplewis dplewis mentioned this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Logout mutation w/o X-Parse-Session-Token header causes internal server error
3 participants