-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL: Remove viewer from logout mutation #7029
GraphQL: Remove viewer from logout mutation #7029
Conversation
Thanks for the PR. It looks good to me. But Travis is not working now and we will have to wait it to check the tests. About the mongodb-runner @dplewis do you have any thoughts? |
yeah i see that travis was not launched, and also what do you think about switching asap from Travis to Github action ? |
That's an idea. Do you have experience with GitHub actions? |
Yes, i currently use GitHub action for many projects :), I think the migration could be easy, I can give a try asap ! |
I am on it right now. I will push what I've done so far so you can double check. |
Note: Labels removed to comply with #6984. Labels apply to issues only. We'll add a bot for this. Any suggestion for PR labels please discuss in the referenced thread. |
sorry @mtrezza i should check the new label policy |
@Moumouls No worries, it's still experimental and we're figuring things out as we go. Instructions on label usage will be improved to be easier readable once we have figured this out. If you have any suggestions please feel free to post in the referenced thread 🙂 |
@davimacedo LGTY ? 😄 |
I also updated mongo db runner to direct github master branch repo since 4.8.0 (published in Jan 2020) do not work on Node 14/15. We need to wait for their new package release. (https://github.com/mongodb-js/runner)