Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting patterns in classNames for Live Queries #7131

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

Nes-si
Copy link
Contributor

@Nes-si Nes-si commented Jan 19, 2021

New Pull Request Checklist

Issue Description

The PR allows to use patterns (regexps) in LiveQuery's parameter classNames. This makes it possible to use subscription at classes that are not known at the time of server configuring.
There is full backward compatibility.

Related issue

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #7131 (1772e79) into master (034ea5c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7131      +/-   ##
==========================================
+ Coverage   93.89%   93.92%   +0.02%     
==========================================
  Files         169      169              
  Lines       12530    12535       +5     
==========================================
+ Hits        11765    11773       +8     
+ Misses        765      762       -3     
Impacted Files Coverage Δ
src/Controllers/LiveQueryController.js 96.55% <100.00%> (+0.71%) ⬆️
src/RestWrite.js 93.67% <0.00%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.51% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034ea5c...1772e79. Read the comment docs.

@Nes-si Nes-si marked this pull request as ready for review January 19, 2021 21:00
@dplewis
Copy link
Member

dplewis commented Jan 19, 2021

Looks good, thank you for getting started on this highly requested feature. Can you write a test case to ensure it works?

@dplewis dplewis requested review from mtrezza and davimacedo January 19, 2021 21:18
@Nes-si
Copy link
Contributor Author

Nes-si commented Jan 19, 2021

Is it ok?

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit e592212 into parse-community:master Jan 19, 2021
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Jan 28, 2021
* add-account-unlock-on-password-reset:
  moved changelog entry to correct position
  Added docs entry
  added changelog entry
  added account policy option
  added account unlock on password reset
  fix: upgrade ws from 7.4.1 to 7.4.2 (parse-community#7132)
  Supporting patterns in classNames for Live Queries (parse-community#7131)
  add api mail adapter to mail adapter list (parse-community#7126)

# Conflicts:
#	CHANGELOG.md
#	src/Config.js
#	src/Options/Definitions.js
rsouzas pushed a commit to back4app/parse-server that referenced this pull request Jan 29, 2021
)

* Parse LiveQuery Server. Supporting patterns in classNames.

* Parse LiveQuery Server. Supporting patterns in classNames. Small optimisation.

* Parse LiveQuery Server. Supporting patterns in classNames. Adding info to changelog.

* Parse LiveQuery Server. Supporting patterns in classNames. Test case.
dplewis pushed a commit that referenced this pull request Feb 21, 2021
* Parse LiveQuery Server. Supporting patterns in classNames.

* Parse LiveQuery Server. Supporting patterns in classNames. Small optimisation.

* Parse LiveQuery Server. Supporting patterns in classNames. Adding info to changelog.

* Parse LiveQuery Server. Supporting patterns in classNames. Test case.
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants