Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: allow options to be async on Cloud Validator #7155

Merged
merged 10 commits into from
Feb 23, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 31, 2021

New Pull Request Checklist

Issue Description

You can set a function to a Validator's field options, but it can't currently be async.

Related issue: #7140

Approach

Allows options to be async and resolves in Parallel with any other validator options.

TODOs before merging

  • Add test cases
  • Add entry to changelog

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #7155 (33f7edd) into master (a649a9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7155   +/-   ##
=======================================
  Coverage   94.00%   94.01%           
=======================================
  Files         172      172           
  Lines       12868    12873    +5     
=======================================
+ Hits        12097    12102    +5     
  Misses        771      771           
Impacted Files Coverage Δ
src/StatusHandler.js 98.56% <100.00%> (+0.01%) ⬆️
src/triggers.js 94.92% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a649a9e...33f7edd. Read the comment docs.

src/triggers.js Outdated Show resolved Hide resolved
@dblythy dblythy requested a review from Moumouls February 11, 2021 13:55
CHANGELOG.md Show resolved Hide resolved
spec/CloudCode.Validator.spec.js Show resolved Hide resolved
spec/CloudCode.Validator.spec.js Outdated Show resolved Hide resolved
* Ensure pushStatus is properly running

* remove duplicate test
@dplewis dplewis self-requested a review February 20, 2021 21:25
@dplewis dplewis merged commit 91a0108 into parse-community:master Feb 23, 2021
@dplewis dplewis deleted the asyncOptions branch February 23, 2021 08:56
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants