Excluding keys that have trailing "edges.node" on them

[cjbland]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

The issue is trying to call resolvers on relations do not work with Postgres. For example the following query will fail when using Posgres:

roles(where: { users: { have: { id: { equalTo: $userId } } } }) {
  edges {
    node {
      name
      users {
        edges {
          node {
            username
          }
        }
      }
    }
  }
}

Related issue: #6419

Approach

The approach with this PR is to ignore any keys that have a trailing edges.node on them. Using the example above, it will initially have these select keys:

This fails because the following fields are being sent to the resolver:

[
  'edges.node.name',
  'edges.node.users.edges.node.username'
]

This then gets modified down to:

[
  'name',
  'users.edges.node.username'
]

This array gets passed as the "keys" to the REST query. Down the processing chain the RestQuery will chop off everything after the first . so then we're left with ['name', 'users'] and users is not a valid column on the _Role table. This PR will drop the users.edges.node.username key all together as it would never need to be a selected key in any query.

TODOs before merging

• Add test cases
• Add entry to changelog
• Add changes to documentation (guides, repository pages, in-code descriptions)
• Add security check
• Add new Parse Error codes to Parse JS SDK
• ...

[codecov]

Codecov Report

Merging #7273 (c159b5f) into master (637326d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7273      +/-   ##
==========================================
- Coverage   93.94%   93.89%   -0.05%     
==========================================
  Files         179      179              
  Lines       13152    13154       +2     
==========================================
- Hits        12355    12351       -4     
- Misses        797      803       +6     

Impacted Files	Coverage Δ
src/GraphQL/loaders/parseClassQueries.js	98.00% <100.00%> (+0.04%)	⬆️
src/GraphQL/loaders/parseClassTypes.js	94.23% <100.00%> (+0.03%)	⬆️
src/batch.js	91.37% <0.00%> (-1.73%)	⬇️
src/ParseServerRESTController.js	97.01% <0.00%> (-1.50%)	⬇️
src/Adapters/Files/GridFSBucketAdapter.js	79.50% <0.00%> (-0.82%)	⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	92.59% <0.00%> (-0.66%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637326d...c159b5f. Read the comment docs.

[davimacedo]

Thanks for the PR. Could you please change this test to also run on Postgres so we can make sure it will always work? https://github.com/parse-community/parse-server/blob/master/spec/ParseGraphQLServer.spec.js#L8257

[cjbland]

Any recommendation on how I could test this locally? I'm a little confused as to why it's only failing on that one version of Postgres and I'd like to avoid pushing debug changes over and over.

[davimacedo]

Something like:

export PARSE_SERVER_TEST_DB=postgres
export PARSE_SERVER_TEST_DATABASE_URI=your_local_postgres_uri
npm run testonly

[davimacedo]

LGTM!

[parseplatformorg]

🎉 This change has been released in version 5.0.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.0.0