Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logout with invalid session #7278

Closed

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Mar 18, 2021

New Pull Request Checklist

Issue Description

Returns "success" for logout call even if associated session is invalid. First commit is failing test to show how users can get stuck not being able to logout if their session becomes invalid.

Related issue: Closes #7277

Approach

TODOs before merging

  • Add test cases
  • Add entry to changelog

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #7278 (3426a46) into master (a05e9b1) will decrease coverage by 9.31%.
The diff coverage is 100.00%.

❗ Current head 3426a46 differs from pull request most recent head 788dbda. Consider uploading reports for the commit 788dbda to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7278      +/-   ##
==========================================
- Coverage   93.91%   84.59%   -9.32%     
==========================================
  Files         179      179              
  Lines       13154    13156       +2     
==========================================
- Hits        12353    11129    -1224     
- Misses        801     2027    +1226     
Impacted Files Coverage Δ
src/middlewares.js 96.74% <100.00%> (-0.44%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.47% <0.00%> (-92.90%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 4.76% <0.00%> (-61.91%) ⬇️
src/Controllers/UserController.js 95.27% <0.00%> (-2.37%) ⬇️
src/Controllers/FilesController.js 92.00% <0.00%> (-2.00%) ⬇️
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/Controllers/index.js 96.66% <0.00%> (-1.12%) ⬇️
src/RestWrite.js 93.51% <0.00%> (-0.49%) ⬇️
src/Controllers/SchemaController.js 97.16% <0.00%> (-0.19%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05e9b1...788dbda. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, this should not be solved on the server side but on the client side in my opinion.

@dblythy dblythy closed this Mar 18, 2021
@dblythy dblythy deleted the allowLogoutOnInvalidSession branch March 18, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow logout with invalid session
2 participants