-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mailgun adapter with mock adapter #7321
Replace mailgun adapter with mock adapter #7321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
- Coverage 93.93% 93.89% -0.04%
==========================================
Files 181 181
Lines 13194 13194
==========================================
- Hits 12394 12389 -5
- Misses 800 805 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note: The adapter has to be removed from README before merge. |
also cleaned up readme and definitions of password / account policy
Removed simple-mailgun-adapter from README Also cleaned up the |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Parse Server has a dependency on parse-server-simple-mailgun-adapter, which poses several issues. Parse Server uses it just for adapter loading tests.
Related issue: closes #7320
Approach
Replaced dependency on parse-server-simple-mailgun-adapter with new
MockMailAdapter
sub-package inside Parse Server package.This is a breaking change, because the adapter has been part of Parse Server and therefore a mail adapter that was available without adding it manually as dependency. For sake of clean-up for the next release, this will be a breaking change without phased deprecation.
TODOs before merging