-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix failing tests after removal of session token #7599
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7599 +/- ##
==========================================
+ Coverage 93.94% 93.96% +0.01%
==========================================
Files 181 181
Lines 13289 13289
==========================================
+ Hits 12485 12487 +2
+ Misses 804 802 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I sense some Swift syntax here 🙂 I take it that the 4.10.4 release is fine, it was just the tests themselves?
I assume these were last-minute changes after the last local test run, that's why they were overlooked? We should probably establish a protocol for the reviewer that says the first step before merging an advisory is running at least one mongodb and one postgres test locally.
Yep! I guess the
It was my mistake for running the tests only on Node 16!
This sounds like a good idea to avoid this happening in the future. Perhaps we should also have the tests run locally on the same Node versions as the CI |
Right, so it should probably be at least one local test for:
And if backported, such a test for each branch. Is Parse Server already Node 16 compatible, because you said you ran it on Node 16? I thought there was still an open issue? |
Actually I’m mistaken - it would’ve been Node 15 / npm 6 otherwise lockfile would be v2 |
Got it, thanks |
Could it be that this is not in the 4.10.4 release? Running the tests seem to fail on exactly this issue, see #7658 |
I'm currently running the tests with node 14, so far seen the same error as in #7600 but they are still running... Basically looks like the 4.x.x branch won't work with the current test-workflows as these require node 10. |
Let's discuss in #7658 |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Merging security fix 834ae36 introduced failing tests.
Related issue: #n/a
Approach
Fixes failing tests.
TODOs before merging
n/a