Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve PushController tests #7760

Merged
merged 3 commits into from
Jan 2, 2022
Merged

test: improve PushController tests #7760

merged 3 commits into from
Jan 2, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 2, 2022

New Pull Request Checklist

Issue Description

Every once in awhile some of these tests fail on Postgres. The timer is set low, so giving it a small bump.

Related issue: #7180

Approach

Improve some of the PushController tests to use async/await. Increase sleep timer to prevent random failures on Postgres.

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 2, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #7760 (3e7c50a) into alpha (caf4a23) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7760      +/-   ##
==========================================
+ Coverage   93.95%   93.96%   +0.01%     
==========================================
  Files         183      183              
  Lines       13640    13640              
==========================================
+ Hits        12815    12817       +2     
+ Misses        825      823       -2     
Impacted Files Coverage Δ
src/RestWrite.js 94.20% <0.00%> (+0.15%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b9a56...3e7c50a. Read the comment docs.

@mtrezza mtrezza changed the title refactor: improve PushController tests test: improve PushController tests Jan 2, 2022
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 2, 2022

@mtrezza this is ready for review

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see all beautiful green!

@mtrezza mtrezza merged commit 7af5de4 into parse-community:alpha Jan 2, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.16

@cbaker6 cbaker6 deleted the pushTests branch January 2, 2022 18:27
@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 2, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants