-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
docs: jsdoc clean theme #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: jsdoc clean theme #8021
Conversation
Thanks for opening this pull request!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this was correctly installed. There are no changes to package-lock.
oh! sorry. i forgot commiting the package-lock.json as i installed everything via yarn. |
HI @okobsamoht , i think you need to restore the package lock from alpha branch. To easily avoid a change to v2, use @mtrezza what do you think about switching to lock v2 in a separate PR since it's now the default version since Node 16/Npm 8 ? |
As long as we're supporting a Node version that uses v1 natively, we stick with v1 (despite backwards-compatibility). |
# Conflicts: # package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restored package-lock file from current parse-server/alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a related open issue for this PR? I can't find the ref in the PR description.
I also don't believe this is the full PR because I remember in the issue I've mentioned a customization in the current template. That's why we need the issue referenced in the PR.
thanks @okobsamoht for the package lock restoration. Is it possible to add some screenshot of the new jsdoc theme here ? |
here is the issure: #8017 i'll try the customization in the current theme |
Closing via #8519 |
New Pull Request Checklist
Issue Description
Modernize API doc template
change the jsdoc theme form the @parse/minami to clean-jsdoc-theme
TODOs before merging