Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add retries for flaky Postgres tests #8214

Closed
wants to merge 4 commits into from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Oct 6, 2022

New Pull Request Checklist

Issue Description

Postgres can be flaky - adds 3 retries to postgres tests

Related issue: n/a

Approach

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 6, 2022

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 93.96% // Head: 93.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1f26c50) compared to base (2a82d19).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8214   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         182      182           
  Lines       13744    13744           
=======================================
+ Hits        12914    12915    +1     
+ Misses        830      829    -1     
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is this ready for merge?

@dblythy
Copy link
Member Author

dblythy commented Oct 6, 2022

Yep!

@mtrezza mtrezza changed the title ci: add Postgres retries ci: add retries for flaky Postgres tests Oct 6, 2022
@mtrezza
Copy link
Member

mtrezza commented Oct 6, 2022

This is effectively covering the flakiness of the Postgres tests - practical but this will also make it unlikely that someone will fix the actual flakiness. So I'm actually not sure whether this is beneficial?

@dblythy
Copy link
Member Author

dblythy commented Oct 6, 2022

Good point actually, if a test is added that is flaky, we will never know with this method

#7180

@dblythy dblythy closed this Oct 6, 2022
@dblythy dblythy deleted the allow-failures branch October 6, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants