Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix flaky tests #8468

Merged
merged 23 commits into from
Mar 10, 2023
Merged

ci: Fix flaky tests #8468

merged 23 commits into from
Mar 10, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Mar 8, 2023 •
edited by mtrezza
Loading

Pull Request

Issue

Closes: #7180

Approach

Tasks

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 8, 2023 •
edited
Loading

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (4ce135a) 94.30% compared to head (345f1a5) 94.34%.

❗ Current head 345f1a5 differs from pull request most recent head 565f86a. Consider uploading reports for the commit 565f86a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8468      +/-   ##
==========================================
+ Coverage   94.30%   94.34%   +0.03%     
==========================================
  Files         183      183              
  Lines       14484    14515      +31     
==========================================
+ Hits        13659    13694      +35     
+ Misses        825      821       -4
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/Config.js 91.01% <100.00%> (+0.13%) ⬆️
src/TestUtils.js 93.33% <100.00%> (+5.83%) ⬆️
src/cloud-code/Parse.Cloud.js 99.29% <100.00%> (+0.01%) ⬆️
src/middlewares.js 96.98% <100.00%> (+0.18%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy changed the title wip: flaky test ci: fix flaky tests Mar 8, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: fix flaky tests ci: Fix flaky tests Mar 8, 2023
@dblythy
Copy link
Member Author

dblythy commented Mar 8, 2023

Postgres tests can still be occasionally flaky, but should resolve most of the test related flakiness

@dblythy dblythy requested a review from a team March 8, 2023 03:03
@dblythy dblythy removed the request for review from a team March 8, 2023 04:12
@dblythy dblythy closed this Mar 8, 2023
@dblythy dblythy reopened this Mar 8, 2023
@dblythy dblythy requested a review from a team March 8, 2023 05:31
@dblythy dblythy mentioned this pull request Mar 9, 2023
Merged
1 task
mtrezza
mtrezza requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also making changes in source files, not only test or CI files. We need to either separate that into another PR or change the focus of this PR to describe the source changes.

@dblythy
Copy link
Member Author

dblythy commented Mar 10, 2023

The source changes are related to the internal Parse.Cloud._removeAllHooks, which is an internal method used in testing to unregister cloud triggers. As this is only used in our test suite (and not intended for public use) I don’t think additional PRs are required

mtrezza
mtrezza approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 65e5879 into parse-community:alpha Mar 10, 2023
@dblythy dblythy deleted the flaky-test branch March 11, 2023 02:27
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.8

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
@dplewis dplewis mentioned this pull request Jul 17, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky tests
3 participants
@dblythy @parseplatformorg @mtrezza