Skip to content

refactor: Replace deprecated substr with substring #8644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 19, 2023

Pull Request

Issue

substr() has been deprecated.

Closes: #8645

Approach

  • Use substring() instead and fix issues where needed
  • Refactor rotateEncryptionKey() in GridFSBucketAdapter.js to use async/await since already refactoring substr() in the same file

Tasks

  • Ensure tests pass

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 19, 2023

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.03 🎉

Comparison is base (45301a6) 94.41% compared to head (1e8ce50) 94.44%.

❗ Current head 1e8ce50 differs from pull request most recent head f8f095b. Consider uploading reports for the commit f8f095b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8644      +/-   ##
==========================================
+ Coverage   94.41%   94.44%   +0.03%     
==========================================
  Files         184      184              
  Lines       14613    14604       -9     
==========================================
- Hits        13797    13793       -4     
+ Misses        816      811       -5     
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.74% <83.33%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 96.96% <100.00%> (+2.64%) ⬆️
src/Config.js 91.27% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 19, 2023

@mtrezza @dblythy this is ready for review

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza changed the title refactor: Replace deprecated substr with substring refactor: Replace deprecated substr with substring Jun 20, 2023
@mtrezza mtrezza merged commit 3710da7 into parse-community:alpha Jun 20, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 20, 2023
@cbaker6 cbaker6 deleted the substri branch June 20, 2023 11:58
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server uses deprecated substr()
3 participants