-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: Replace deprecated substr
with substring
#8644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8644 +/- ##
==========================================
+ Coverage 94.41% 94.44% +0.03%
==========================================
Files 184 184
Lines 14613 14604 -9
==========================================
- Hits 13797 13793 -4
+ Misses 816 811 -5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
substr
with substring
🎉 This change has been released in version 6.3.0-alpha.2 |
🎉 This change has been released in version 6.4.0-beta.1 |
🎉 This change has been released in version 6.4.0-alpha.1 |
🎉 This change has been released in version 6.4.0 |
Pull Request
Issue
substr()
has been deprecated.Closes: #8645
Approach
substring()
instead and fix issues where neededrotateEncryptionKey()
inGridFSBucketAdapter.js
to use async/await since already refactoringsubstr()
in the same fileTasks