Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeSave changes should propagate to the response #865

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Mar 6, 2016

For issue #457

@codecov-io
Copy link

Current coverage is 91.66%

Merging #865 into master will decrease coverage by -0.02% as of 67008cb

@@            master    #865   diff @@
======================================
  Files           71      71       
  Stmts         4102    4105     +3
  Branches       845     846     +1
  Methods          0       0       
======================================
+ Hit           3761    3763     +2
  Partial         10      10       
- Missed         331     332     +1

Review entire Coverage Diff as of 67008cb

Powered by Codecov. Updated on successful CI builds.

@nlutsenko
Copy link
Contributor

Looks good, though this is a hack and I feel we need to find a better way for this information. Or rebuild the flow here slightly to support this.

gfosco added a commit that referenced this pull request Mar 6, 2016
beforeSave changes should propagate to the response
@gfosco gfosco merged commit 7e153d4 into master Mar 6, 2016
@gfosco gfosco deleted the fosco.457 branch March 6, 2016 10:50
@mmazzarolo
Copy link

Hi!
Just to let you know, it seems it didn't fix #866, on parse-server 2.1.5 changes are still not propagated to response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants