-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add ability to exclude tests via ID in testExclusionList.json
#8774
Conversation
Thanks for opening this pull request! |
testExclusionList.json
Looks good, could you try again with the refactor I've done, to make sure it works? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8774 +/- ##
==========================================
- Coverage 94.33% 93.95% -0.38%
==========================================
Files 186 186
Lines 14780 14780
==========================================
- Hits 13942 13886 -56
- Misses 838 894 +56 ☔ View full report in Codecov by Sentry. |
Noted that this implementation won't work for tests that use any of the custom To address this, we could:
|
…into testExclusionList
added the suggested changes, tested, lgtm |
Did you consider #8774 (comment)? |
I added the requested support it_id('bbd9e2f6-7f61-458f-98f2-4a563586cd8d',it_only_node_version("v16.20.1"))('geo line', async done => { The test exclusion list overrides all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Waiting for CI to pass...
🎉 This change has been released in version 6.4.0-alpha.6 |
🎉 This change has been released in version 6.5.0-beta.1 |
🎉 This change has been released in version 6.5.0-alpha.1 |
🎉 This change has been released in version 6.5.0 |
🎉 This change has been released in version 7.0.0 |
Pull Request
Issue
Add support for testExclusionList so different adapter repos can exclude tests specific to that adapter.
Move test exclusion out of the main parse-server repo
Closes: #8714
Approach
This PR adds the ability in helper.js to exclude tests based on a uuid
A file, testExclusionList is created in the spec dir and looks like
and tests to be excluded are prefixed like
it_id('bbd9e2f6-7f61-458f-98f2-4a563586cd8d')('geo line', async done => {