Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docs for Parse Server options masterKeyIps, maintenanceKeyIps #8814

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Nov 18, 2023

Pull Request

Issue

Closes: #8421

Approach

Lack of documentation causes confusion as to how to use the masterKeyIps and maintenanceKeyIps options.

Tasks

  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ef1986) 94.32% compared to head (cd9d104) 93.93%.
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8814      +/-   ##
==========================================
- Coverage   94.32%   93.93%   -0.40%     
==========================================
  Files         186      186              
  Lines       14798    14798              
==========================================
- Hits        13958    13900      -58     
- Misses        840      898      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 7597319 into parse-community:alpha Nov 18, 2023
24 of 26 checks passed
@mtrezza mtrezza deleted the docs/improve-masterKeyIps-docs branch November 18, 2023 14:43
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 19, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.0

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 19, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The option "masterKeyIps" cannot be disabled
2 participants