Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failing Docker release by removing arm/v6 and arm/v7 support #8977

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 3, 2024

Pull Request

Issue

New docker images are not being created on releases. Instead, the CI just hangs.

Closes: #8904

Approach

Remove builds for arm/v6 and arm/v7 platforms as they are causing issues. These are Raspberry Pi 2 and 3 builds. Someone can create a PR in the future to add these back.

Tasks

  • Switch docker image to use 18-alpine to keep the version of node the server was originally built for
  • Remove builds for arm/v6 and arm/v7 platforms
  • Ensure CI passes

Signed-off-by: Corey <coreyearleon@icloud.com>
Copy link

parse-github-assistant bot commented Mar 3, 2024

Thanks for opening this pull request!

cbaker6 added 3 commits March 3, 2024 09:26
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
@cbaker6 cbaker6 changed the title fix: Docker release versions fix: Docker release 6.x versions Mar 3, 2024
@cbaker6
Copy link
Contributor Author

cbaker6 commented Mar 3, 2024

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (47184f0) to head (4228e8d).

Additional details and impacted files
@@              Coverage Diff               @@
##           release-6.x.x    #8977   +/-   ##
==============================================
  Coverage          94.32%   94.32%           
==============================================
  Files                186      186           
  Lines              14827    14827           
==============================================
  Hits               13985    13985           
  Misses               842      842           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cbaker6 added 5 commits March 3, 2024 17:23
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
Signed-off-by: Corey <coreyearleon@icloud.com>
@mtrezza mtrezza changed the title fix: Docker release 6.x versions ci: Fix failing Docker release by removing arm/v6 and arm/v7 support Mar 5, 2024
@mtrezza mtrezza merged commit 9282bc5 into parse-community:release-6.x.x Mar 5, 2024
28 checks passed
@cbaker6 cbaker6 deleted the patch-3 branch March 5, 2024 15:34
@cbaker6
Copy link
Contributor Author

cbaker6 commented Mar 5, 2024

@mtrezza can you try the manual release on this branch?

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants