-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Saving object with a pointer field set to undefined
throws error for Postgres
#9147
base: alpha
Are you sure you want to change the base?
fix: Saving object with a pointer field set to undefined
throws error for Postgres
#9147
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
spec/PostgresStorageAdapter.spec.js
Outdated
@@ -570,6 +570,35 @@ describe_only_db('postgres')('PostgresStorageAdapter', () => { | |||
await adapter.deleteIdempotencyFunction(); | |||
await client.none(qs); | |||
}); | |||
|
|||
it('saves object with a pointer field set to undefined', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be moved to where the existing pointer tests are, as it's not a postgres specific test, even if the issue occurs only with postgres.
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
undefined
throws error for Postgres
Test passes for Postgres and MongoDB. Is this issue related to your custom code? |
I just found out how to test with postgres locally so I'm gonna try setting that up properly first. My issue might be because I didn't configure postgres for parse correctly. |
@andrewalc sure, let us know how it goes, and whether the related issue can be closed. |
posted an update in the issue here, might try again if i find some time but it seems like the case i have refuses to fail in this repo |
Pull Request
Issue
Closes: #9146
Approach
Work in progress, attempting to write a failing test case. Need to see if it fails for Postgres in CI (afaik i can only test on mongo locally. It passes for mongo but shouldn't for postgres)
Tasks