ci: Fix flaky direct access transaction tests

[dplewis]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

#9210 fixed the transaction flaky test for batch.spec.js. This PR fixes it for the ParseServerRESTConroller

https://github.com/parse-community/parse-server/actions/runs/10019940136/job/27697049679?pr=9218

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (4d86ace) to head (ee341fd).
Report is 24 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #9235      +/-   ##
==========================================
+ Coverage   93.75%   93.76%   +0.01%     
==========================================
  Files         184      184              
  Lines       14675    14715      +40     
==========================================
+ Hits        13758    13797      +39     
- Misses        917      918       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtrezza]

That's an interesting fix; is it more reliable to reference a spy in a var let createSpy = spyOn... than to set the spy spyOn(databaseAdapter, 'createObject').and.callThrough() and then try to access it via the spied upon obj databaseAdapter.createObject.calls?

[dplewis]

Using let createSpy = spyOn.. in a beforeEach guarantees the mock resets and allow you to programmatically reset the mocks for finer control of the tests.

[parseplatformorg]

🎉 This change has been released in version 7.3.0-alpha.7

[parseplatformorg]

🎉 This change has been released in version 7.3.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 7.3.0