Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog and update to 2.1.5 #933

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Changelog and update to 2.1.5 #933

merged 1 commit into from
Mar 9, 2016

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Mar 9, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 91.30%

Merging #933 into master will not affect coverage as of 0f0f16f

@@            master   #933   diff @@
=====================================
  Files           72     72       
  Stmts         4301   4301       
  Branches       862    862       
  Methods          0      0       
=====================================
  Hit           3927   3927       
  Partial         10     10       
  Missed         364    364       

Review entire Coverage Diff as of 0f0f16f

Powered by Codecov. Updated on successful CI builds.

@flovilmart
Copy link
Contributor

We may wanna wait for that one #932 as we have a major issue with FB/OAuth login

@drew-gross
Copy link
Contributor

So far the changelog has only been including stuff that the end user sees (eg. the don't care about less warnings when running tests or converting source code from ES5 to ES6). @nlutsenko wanted to put that info in releases and have the changelog include literally everything, are you going to do that for this release? Eg. put a more end-user centric release notes/changelog into releases?

@gfosco
Copy link
Contributor Author

gfosco commented Mar 9, 2016

I included all of the PRs, didn't evaluate which was end-user facing or not... I am not sure it's worth the additional effort to make them less comprehensive, so my vote is for including them.

@aziz92
Copy link

aziz92 commented Mar 9, 2016

Is there a way I can install 2.1.5 before it's officially released?

@drew-gross
Copy link
Contributor

I think it's important to have a list of user facing changes so that people can evaluate whether or not to update to the newest version. What @nlutsenko wanted was to have the user facing changes go into "releases" tab and have changelog be comprehensive. As long as the list of user facing changes is somewhere, I'm cool with that.

@nlutsenko
Copy link
Contributor

Yes. We can even skip the New/Improved/Fixed portion and just list things chronologically, but it's up to us, and there are pros and cons to both listing changes in sections vs not doing it.
If people want to see the user facing things - they go look at the Releases page (I think that's what it's for). We can even cross-link them 😁
The purpose of changelog is to show what changed in any given version, up to the slightest detail.
For example, if people are forking the server (which is a legitimate use case) and have their changes there - any change, even internal, is going to impact people.

Another use case - if we have pre-releases, like RCs which is supported for GitHub - a good example is Docker. Things that go into Releases is user visible, but those things don't necessarily need to go into Changelog.

Also documenting PRs instead of git commits is a way better approach, since it reduces amount of noise in the changelog...

gfosco added a commit that referenced this pull request Mar 9, 2016
@gfosco gfosco merged commit 72362bc into master Mar 9, 2016
@gfosco gfosco deleted the fosco.215 branch March 9, 2016 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants