Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 73 additions & 89 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"pluralize": "8.0.0",
"punycode": "2.3.1",
"rate-limit-redis": "4.2.0",
"redis": "4.7.0",
"redis": "5.10.0",
"semver": "7.7.2",
"subscriptions-transport-ws": "0.11.0",
"tv4": "1.3.0",
Expand Down
2 changes: 0 additions & 2 deletions spec/RedisPubSub.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ describe('RedisPubSub', function () {
expect(redis.createClient).toHaveBeenCalledWith({
url: 'redisAddress',
socket_keepalive: true,
no_ready_check: true,
});
});

Expand All @@ -35,7 +34,6 @@ describe('RedisPubSub', function () {
expect(redis.createClient).toHaveBeenCalledWith({
url: 'redisAddress',
socket_keepalive: true,
no_ready_check: true,
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/Adapters/Cache/RedisCacheAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class RedisCacheAdapter {
return;
}
try {
await this.client.quit();
await this.client.close();
} catch (err) {
logger.error('RedisCacheAdapter error on shutdown', { error: err });
}
Expand Down
2 changes: 0 additions & 2 deletions src/Adapters/PubSub/RedisPubSub.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { createClient } from 'redis';
import { logger } from '../../logger';

function createPublisher({ redisURL, redisOptions = {} }): any {
redisOptions.no_ready_check = true;
const client = createClient({ url: redisURL, ...redisOptions });
client.on('error', err => { logger.error('RedisPubSub Publisher client error', { error: err }) });
client.on('connect', () => {});
Expand All @@ -12,7 +11,6 @@ function createPublisher({ redisURL, redisOptions = {} }): any {
}

function createSubscriber({ redisURL, redisOptions = {} }): any {
redisOptions.no_ready_check = true;
const client = createClient({ url: redisURL, ...redisOptions });
client.on('error', err => { logger.error('RedisPubSub Subscriber client error', { error: err }) });
client.on('connect', () => {});
Expand Down
4 changes: 2 additions & 2 deletions src/LiveQuery/ParseLiveQueryServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ class ParseLiveQueryServer {
this.subscriber.close?.(),
]);
}
if (typeof this.subscriber.quit === 'function') {
if (typeof this.subscriber.close === 'function') {
try {
await this.subscriber.quit();
await this.subscriber.close();
} catch (err) {
logger.error('PubSubAdapter error on shutdown', { error: err });
}
Expand Down
Loading