Skip to content

Check if the data is null when get platform arn #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Check if the data is null when get platform arn #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions spec/SNSPushAdapter.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,24 @@ describe('SNSPushAdapter', () => {
});
});

it('errors exchanging device tokens for an Amazon Resource Number (ARN) because data is null', (done) => {

// Mock out Amazon SNS token exchange
var snsSender = jasmine.createSpyObj('sns', ['createPlatformEndpoint']);
snsPushAdapter.sns = snsSender;

snsSender.createPlatformEndpoint.and.callFake(function(object, callback) {
callback("error", null);
});

var promise = snsPushAdapter.exchangeTokenPromise(makeDevice("androidToken"), "GCM_ID");

promise.catch(function() {
expect(snsSender.createPlatformEndpoint).toHaveBeenCalled();
done();
});
});

it('errors exchanging device tokens for an Amazon Resource Number (ARN)', (done) => {

// Mock out Amazon SNS token exchange
Expand Down
2 changes: 1 addition & 1 deletion src/SNSPushAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ SNSPushAdapter.prototype.exchangeTokenPromise = function (device, platformARN) {
return new Parse.Promise((resolve, reject) => {

this.getPlatformArn(device, platformARN, (err, data) => {
if (data.EndpointArn) {
if (data !== null && data.EndpointArn) {
resolve({device: device, arn: data.EndpointArn});
}
else
Expand Down